-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
According to Bruno Haible on 5/13/2009 5:40 PM:
> Eric and Jim wrote:
>> Looks good.
>
> OK, I committed the patch.
$ ./gnulib-tool --with-tests --test memchr
...
executing aclocal -I ../glm4
configure.ac:103: warning: AC_COMPILE_IFELSE was called before
AC_USE_SYSTEM_EXTENSIONS
../glm4/mmap-anon.m4:16: gl_FUNC_MMAP_ANON is expanded from...
configure.ac:17: gl_INIT is expanded from...
configure.ac:103: the top level
I committed this follow-up to silence the warning. Meanwhile, there are
still other macros that use AC_USE_SYSTEM_EXTENSIONS instead of
gl_USE_SYSTEM_EXTENSIONS; should we revisit those?
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAkoLhKYACgkQ84KuGfSFAYC6/QCghi78aVaT3F6IARX+ZY2w2EOw
/NEAn260TDLkf948J+kOl9AYDrVsNUF4
=0lXl
-----END PGP SIGNATURE-----
>From 12f51457a97474206a16b12b360b72e623c6357c Mon Sep 17 00:00:00 2001
From: Eric Blake <e...@byu.net>
Date: Wed, 13 May 2009 20:38:30 -0600
Subject: [PATCH] mmap-anon: avoid out-of-order autoconf expansion
* m4/mmap-anon.m4 (gl_FUNC_MMAP_ANON): Use correct
SYSTEM_EXTENSIONS macro to silence warnings from autoconf 2.63b.
* modules/memchr-tests (Depends-on): Add extensions.
* modules/memchr2-tests (Depends-on): Add extensions.
* modules/memcmp-tests (Depends-on): Add extensions.
* modules/memmem-tests (Depends-on): Add extensions.
* modules/memrchr-tests (Depends-on): Add extensions.
Signed-off-by: Eric Blake <e...@byu.net>
---
ChangeLog | 11 +++++++++++
m4/mmap-anon.m4 | 4 ++--
modules/memchr-tests | 1 +
modules/memchr2-tests | 1 +
modules/memcmp-tests | 1 +
modules/memmem-tests | 1 +
modules/memrchr-tests | 1 +
7 files changed, 18 insertions(+), 2 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index e37b92a..dd0f0c6 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,14 @@
+2009-05-13 Eric Blake <e...@byu.net>
+
+ mmap-anon: avoid out-of-order autoconf expansion
+ * m4/mmap-anon.m4 (gl_FUNC_MMAP_ANON): Use correct
+ SYSTEM_EXTENSIONS macro to silence warnings from autoconf 2.63b.
+ * modules/memchr-tests (Depends-on): Add extensions.
+ * modules/memchr2-tests (Depends-on): Add extensions.
+ * modules/memcmp-tests (Depends-on): Add extensions.
+ * modules/memmem-tests (Depends-on): Add extensions.
+ * modules/memrchr-tests (Depends-on): Add extensions.
+
2009-05-13 Bruno Haible <br...@clisp.org>
Make some tests ISO C 99 compliant.
diff --git a/m4/mmap-anon.m4 b/m4/mmap-anon.m4
index fe624a2..14b6270 100644
--- a/m4/mmap-anon.m4
+++ b/m4/mmap-anon.m4
@@ -1,4 +1,4 @@
-# mmap-anon.m4 serial 7
+# mmap-anon.m4 serial 8
dnl Copyright (C) 2005, 2007, 2009 Free Software Foundation, Inc.
dnl This file is free software; the Free Software Foundation
dnl gives unlimited permission to copy and/or distribute it,
@@ -20,7 +20,7 @@ AC_DEFUN([gl_FUNC_MMAP_ANON],
AC_REQUIRE([AC_PROG_EGREP])
dnl Persuade glibc <sys/mman.h> to define MAP_ANONYMOUS.
- AC_REQUIRE([AC_USE_SYSTEM_EXTENSIONS])
+ AC_REQUIRE([gl_USE_SYSTEM_EXTENSIONS])
# Check for mmap(). Don't use AC_FUNC_MMAP, because it checks too much: it
# fails on HP-UX 11, because MAP_FIXED mappings do not work. But this is
diff --git a/modules/memchr-tests b/modules/memchr-tests
index 5ef506a..c99e557 100644
--- a/modules/memchr-tests
+++ b/modules/memchr-tests
@@ -4,6 +4,7 @@ tests/zerosize-ptr.h
m4/mmap-anon.m4
Depends-on:
+extensions
getpagesize
configure.ac:
diff --git a/modules/memchr2-tests b/modules/memchr2-tests
index 6056e2b..44d220c 100644
--- a/modules/memchr2-tests
+++ b/modules/memchr2-tests
@@ -4,6 +4,7 @@ tests/zerosize-ptr.h
m4/mmap-anon.m4
Depends-on:
+extensions
getpagesize
configure.ac:
diff --git a/modules/memcmp-tests b/modules/memcmp-tests
index df5b7eb..ae1cc38 100644
--- a/modules/memcmp-tests
+++ b/modules/memcmp-tests
@@ -4,6 +4,7 @@ tests/zerosize-ptr.h
m4/mmap-anon.m4
Depends-on:
+extensions
getpagesize
configure.ac:
diff --git a/modules/memmem-tests b/modules/memmem-tests
index e98932e..ff47e51 100644
--- a/modules/memmem-tests
+++ b/modules/memmem-tests
@@ -4,6 +4,7 @@ tests/zerosize-ptr.h
m4/mmap-anon.m4
Depends-on:
+extensions
getpagesize
configure.ac:
diff --git a/modules/memrchr-tests b/modules/memrchr-tests
index 282c570..4885fb1 100644
--- a/modules/memrchr-tests
+++ b/modules/memrchr-tests
@@ -4,6 +4,7 @@ tests/zerosize-ptr.h
m4/mmap-anon.m4
Depends-on:
+extensions
getpagesize
configure.ac:
--
1.6.3.rc3.2.g4b51
