* Bruno Haible wrote on Fri, May 01, 2009 at 11:45:09PM CEST: > > Anyway, one solution is to stick '$(srcdir)/' before every reference of > > those files. > > No, that would require the VPATH build to write those files into the > source directory, which defeats the purpose of a VPATH build.
It is no problem if a git tree updates files in the source tree. Automake's own rules for shipped files of course for Makefile.in and configure do the very same, precisely in order to avoid the problems with files that exist both in the source and in the build tree. All you need to ensure is that distributed files only depend upon distributed files, so they are not regenerated from a tarball build. The GNU Coding Standards are pretty clear about this too. > > Another is to simply ensure they can be built in the build > > tree if needed; done below. > > Thanks for the patch. I added another part, so that the libunistring build > in the situation that you mentioned actually works, and pushed the > combined patch: Thanks. How come you changed the $(MKDIR_P) into @MKDIR_P@, some BSD users would like to be able to override MKDIR_P to not use install-sh -d here (AC_PROG_MKDIR_P does not really test whether the race has been fixed in mkdir). Also, I think it's nice style to use --author for other people's patches. Thanks, Ralf
