Simon Josefsson wrote: > Reuben Thomas <r...@sc3d.org> writes: ... >>> 4. Use of C_SOURCES in sc_* rules. >> >> There seems to be a conflict here between coreutils's approach (use a >> list of exceptions generated from the VCS) and gnulib's (generate a >> list of files to look at). What do you suggest as a next step? In >> either case, the place to fix seems to be _prohibit_regexp (as >> coreutils's maint.mk factors out the common code into this single >> "macro"). > > I think the best would be to adapt the gnulib approach, and patch > coreutils to generate the same list of files. > That way, gnulib maint.mk > doesn't have to assume that the vc is git.
The coreutils way does not assume git. It uses build-aux/vc-list-files, which is a VC-agnostic script. I require maint.mk rules that process only VC-controlled files. Recently I changed two of the remaining ones in coreutils' maint.mk from a find-based approach to the $(VC_LIST_EXCEPT)-based approach used by all of the other rules. The reason was to avoid spending an inordinate amount of time on non-VC'd files that would be processed by find, but not by $(VC_LIST_EXCEPT). Processing non-VC'd files also increases the risk of false-positive matches.
