James Youngman <j...@gnu.org> wrote: > What's the effect of the change? Merely a performance difference? > Or is there a correctness issue?
"slight clarification" The only possible influence on correctness would be if the change affected how "nlinks" was calculated, since that's the only place "is_dir" is used. There is no change in correctness, since "nostat" is only nonzero when ISSET(FTS_PHYSICAL) && ISSET(FTS_NOSTAT) is true. So whether we test just just ISSET(FTS_PHYSICAL) (as now) or the conjunct (before) makes no difference. It's probably not even a measurable performance difference.