Hi Jim, > I'm about to apply the changes induced by the above commands.
What's the rationale of quoting purely numeric m4 arguments, like in AC_DEFINE([FOO], [1], ...) ? It looks a bit like clutter to me, since quoting does not matter here. But if you and Eric and Simon are willing to do this purely for consistency, I'm going with it as well. Please exclude m4/intl.m4 - it is frozen until the next gettext release, see <http://lists.gnu.org/archive/html/bug-gnulib/2008-12/msg00298.html>. You are free to change the other gettext-borrowed .m4 files; I'll port back the changes to gettext. Please don't do these 3 changes to m4/lib-link.m4: -dnl AC_LIB_HAVE_LINKFLAGS(name, dependencies, includes, testcode) +dnl AC_LIB_HAVE_LINKFLAGS([name], [dependencies], [includes], [testcode]) -dnl AC_LIB_FROMPACKAGE(name, package) +dnl AC_LIB_FROMPACKAGE([name], [package]) -dnl AC_LIB_APPENDTOVAR(VAR, CONTENTS) appends the elements of CONTENTS to VAR, +dnl AC_LIB_APPENDTOVAR([VAR], [CONTENTS]) appends the elements of CONTENTS to VAR, (Brackets in the comments usually denote optional parameters.) Likewise in m4/onceonly.m4 and m4/openmp.m4. Could you please bump the serial number of affected files? autopoint now considers the serial numbers of .m4 files. And the copyright year, of course. In m4/argp.m4, the second argument of two AC_DEFINE invocations is not quoted by your patch. In m4/signalblocking.m4, the fourth argument of AC_EGREP_HEADER is not quoted by your patch. > I've taken the unusual step of attaching the compressed diff below. This is welcome; how could I have reviewed the patch otherwise? Bruno
