Re: [PATCH] warnings: Add gl_WARN_COMPLEMENT and gl_WARN_SUPPORTED.

[Simon Josefsson]

Ralf Wildenhues <[EMAIL PROTECTED]> writes:
Paolo Bonzini <[EMAIL PROTECTED]> writes:

...

Thanks for feedback.  I've pushed this.

/Simon

>From ceb6e31c70e82abcb29c58c429683dd89969935b Mon Sep 17 00:00:00 2001
From: Simon Josefsson <[EMAIL PROTECTED]>
Date: Mon, 17 Nov 2008 22:11:30 +0100
Subject: [PATCH] warnings: Improve code.

---
 ChangeLog      |    5 +++++
 m4/warnings.m4 |   15 ++++++++-------
 2 files changed, 13 insertions(+), 7 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 61cd8fa..8ae6063 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,10 @@
 2008-11-17  Simon Josefsson  <[EMAIL PROTECTED]>
 
+       * m4/warnings.m4: Improve code.  Reported by Ralf Wildenhues
+       <[EMAIL PROTECTED]> and Paolo Bonzini <[EMAIL PROTECTED]>.
+
+2008-11-17  Simon Josefsson  <[EMAIL PROTECTED]>
+
        * m4/warnings.m4: Use CPPFLAGS to really check whether the
        parameter works.
 
diff --git a/m4/warnings.m4 b/m4/warnings.m4
index 686d8c7..3585c3e 100644
--- a/m4/warnings.m4
+++ b/m4/warnings.m4
@@ -114,16 +114,17 @@ AC_DEFUN([gl_WARN_SUPPORTED],
 # does OUTVAR = LISTVAR \ REMOVEVAR.
 AC_DEFUN([gl_WARN_COMPLEMENT],
 [
-  FOO=
-  set -- "$2"
-  for w in $_; do
-    case "$3" in
-      *" $w "* | *" $w" | "$w "*)
+  gl_warn_set=
+  set x $2; shift
+  for gl_warn_item
+  do
+    case " $3 " in
+      *" $gl_warn_item "*)
         ;;
       *)
-        FOO="$FOO $w"
+        gl_warn_set="$gl_warn_set $gl_warn_item"
         ;;
     esac
   done
-  $1=$FOO
+  $1=$gl_warn_set
 ])
-- 
1.5.6.5