[EMAIL PROTECTED] writes: > > I think it is a really good idea. If the scripts are distributed in > > gnulib more GNU packages will be using them and improving them. > > Thanks for feedback, I have pushed the module into gnulib. > > Nice. Then we will start using the gnulib version :)
Great. :) The copyright notice said the FSF, I assumed you have papers on file. But it would be good to confirm this. There are some minor things that should probably be addressed eventually: * Stylesheets: should it be inlined into the generated HTML instead? That is often easier. * There seems to be hard-coded assumptions in the code, for example: cut_dir = "/../" I haven't yet understood the code fully though. * For some reason the outputs on my http://josefsson.org/cyclo/ page doesn't have inlined functions, and I get warnings when running the tool: [EMAIL PROTECTED]:~/josefsson.org/cyclo$ make cyclo-libidn.html (cd ~/src/libidn/src && pmccabe ../lib/*.c) | sort -nr | ~/src/gnulib/build-aux/pmccabe2html -v lang=html -v name="GNU Libidn" -v vcurl="http://git.savannah.gnu.org/gitweb/?p=libidn.git;a=blob;f=%FILENAME%;hb=HEAD" -v url="http://www.gnu.org/software/libidn/" > cyclo-libidn.html rm: cannot remove `idna_to_ascii_4i_fn.txt': No such file or directory rm: cannot remove `stringprep_4i_fn.txt': No such file or directory rm: cannot remove `_g_utf8_normalize_wc_fn.txt': No such file or directory rm: cannot remove `punycode_encode_fn.txt': No such file or directory rm: cannot remove `punycode_decode_fn.txt': No such file or directory rm: cannot remove `idna_to_ascii_4z_fn.txt': No such file or directory rm: cannot remove `g_utf8_to_ucs4_fast_fn.txt': No such file or directory rm: cannot remove `tld_get_4_fn.txt': No such file or directory rm: cannot remove `idna_to_unicode_internal_fn.txt': No such file or directory rm: cannot remove `combine_fn.txt': No such file or directory rm: cannot remove `_tld_checkchar_fn.txt': No such file or directory [EMAIL PROTECTED]:~/josefsson.org/cyclo$ /Simon