-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 According to Bruno Haible on 6/9/2008 7:03 PM: |> The corresponding tests/test-strstr.c and friends can continue to |> use alarm() in an environment with SIGALRM ignored, rather than |> also doing the signal reset, because a) we should already be using |> the linear gnulib replacement which should be fast enough to never |> trip the alarm, and b) if we aren't, the user will hopefully notice |> that 'make check' is taking forever and file a bug report. | | I disagree here. When a user does "make check" in gettext, I don't | want to clog his machine for longer than necessary. Also, he is more | likely to report a FAILed test rather than a 3-hours test, because he | doesn't know a priori which tests are supposed to take a while (e.g. | test-getaddrinfo) and which are not. | | May I add the 'signal (SIGALRM, SIG_DFL);' also in the 3 tests?
I don't think it's necessary given argument a, but I am also not opposed to such a change. Go ahead and make the change if you feel better about it that way. - -- Don't work too hard, make some time for fun as well! Eric Blake [EMAIL PROTECTED] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (Cygwin) Comment: Public key at home.comcast.net/~ericblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkhN5WMACgkQ84KuGfSFAYCHGQCfZS8kuU4uA8A1IHlhzE/QzeNG KGAAn2KJfAh91s6c84EZG75XY/8gv97u =DyHo -----END PGP SIGNATURE-----