Bruno Haible <[EMAIL PROTECTED]> wrote: > Hi all, > > So far, I'm done with the 'acl' module changes. Jim, for coreutils an > appropriate NEWS entry is: > > Improved support for access control lists (ACLs): On MacOS X, Solaris 7..10, > HP-UX 11, Tru64, AIX, IRIX 6.5, and Cygwin, "ls -l" now displays the > presence > of an ACL on a file through a '+' sign after the mode, and "cp -p" copies > ACLs.
Thanks a lot! I've added that to NEWS and will make a coreutils snapshot soon. FYI, building failed on Solaris 10, file-has-acl.c: In function 'acl_ace_nontrivial': file-has-acl.c:166: error: 'ALLOW' undeclared (first use in this function) file-has-acl.c:166: error: (Each undeclared identifier is reported only once file-has-acl.c:166: error: for each function it appears in.) file-has-acl.c:169: error: 'ACE_OTHER' undeclared (first use in this function) make[3]: *** [file-has-acl.o] Error 1 With this patch, it compiles: >From 1c6985c95d2d33c12ad08e96650afae7818cc07e Mon Sep 17 00:00:00 2001 From: Jim Meyering <[EMAIL PROTECTED]> Date: Mon, 9 Jun 2008 11:28:55 +0200 Subject: [PATCH] add more guards around definition of ACE_-related code * lib/file-has-acl.c (acl_ace_nontrivial): Define only if ALLOW and ACE_OWNER are also defined. --- lib/file-has-acl.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/file-has-acl.c b/lib/file-has-acl.c index 9589db9..5b851b9 100644 --- a/lib/file-has-acl.c +++ b/lib/file-has-acl.c @@ -146,7 +146,7 @@ acl_nontrivial (int count, aclent_t *entries) return 0; } -# ifdef ACE_GETACL +# if defined ACE_GETACL && defined ALLOW && defined ACE_OWNER /* Test an ACL retrieved with ACE_GETACL. Return 1 if the given ACL, consisting of COUNT entries, is non-trivial. -- 1.5.6.rc1.23.g2f46