It did fetch the newest ChangeLog correctly. But it adds a space before
each line of the ChangeLog entry. Tab after space - that does not smell good.
Strange, the script never adds spaces, all it does on ChangeLog lines is
"s/^ //p" and "s/^+//p".
Also, since the gitweb summary view shows the first line of each commit
message, it would be useful to arrange things so that the first line of the
ChangeLog entry text (without leading tab) becomes the first line of the
git commit message. This means, instead of adding two blank lines, remove
the first line of the ChangeLog entry and the blank line afterwards and also
the next tab.
I usually add a one-line summary anyway exactly for gitweb/gitk, like this:
commit 0f9276dca72b8c0d6482ef380da8c770c053aaa4
Author: Paolo Bonzini <[EMAIL PROTECTED]>
Date: Tue May 27 12:09:04 2008 +0200
add String>>#= primitive
2008-05-27 Paolo Bonzini <[EMAIL PROTECTED]>
* kernel/ByteArray.st: Use VMpr_ArrayedCollection_equal.
* kernel/String.st: Use VMpr_ArrayedCollection_equal.
libgst:
2008-05-27 Paolo Bonzini <[EMAIL PROTECTED]>
* libgst/prims.def: Add VMpr_ArrayedCollection_equal.
Regarding the aborted commit, I never saw it because I just commit and
then amend. One possibility is to add a commit-msg hook that checks for
an empty first line, like this:
bad=`head -1 "$1" | sed -n '/^$\|^20[0-9][0-9]-\|^[a-z/]*:$/=' `
test -z "$bad" || echo 'invalid commit message (missing summary)' >&2
exit $bad
Paolo
