Hi Simon, Le mardi 22 avril 2008 à 10:54 +0200, Simon Josefsson a écrit : > Gnulib's current (minimal) arpa/inet.h for MinGW doesn't declare > inet_ntop and inet_pton, which doesn't exist on MinGW. However, gnulib > has inet_ntop and inet_pton modules with their own header files. This > patch makes sure that arpa/inet.h provides the expected declarations. > Comments? > > Yoann, ok to commit? It has minimal consequences for your module > inet_ntop, it only adds a gl_ARPA_INET_MODULE_INDICATOR([inet_ntop] to > the modules/inet_ntop file. > > We could consider dropping the inet_ntop.h and inet_pton.h files > instead, and just require that you include arpa/inet.h. This would be > slightly cleaner. Yoann, what do you think about that?
Look good to me, please commit. I would also favor removing both inet_ntop.h and inet_pton.h, and use arpa/inet.h for the declarations, as you suggested. Thanks! -- Yoann Vandoorselaere | Responsable R&D / CTO | PreludeIDS Technologies Tel: +33 (0)8 70 70 21 58 Fax: +33(0)4 78 42 21 58 http://www.prelude-ids.com
