Eric Blake wrote: > Unless you're claiming that the compiler might warn about the > explicit shift by 32 bits on platforms where my patch below now > compiles the shift (in a dead code branch) where it was > previously omitted by the #if, but that's okay with me
Yes, that's what I meant. And it's OK with me as well. > * lib/memchr2.c (memchr2): Avoid embedded #if. Thanks! > (should we also change memchr.c to match, since I borrowed from there in > writing memchr2.c)? That's not needed, IMO: That code uses ULONG_MAX which usually carries only a single L, not the suffix LL. Bruno
