Bruno Haible <[EMAIL PROTECTED]> wrote: > Last week, I did: >> 2008-04-13 Bruno Haible <[EMAIL PROTECTED]> >> >> Fix conflict between modules 'canonicalize' and 'canonicalize-lgpl'. >> * lib/canonicalize-lgpl.c: Elide the contents if the 'canonicalize' >> module is also used and while not building the reloc-wrapper. > > This was incorrect. It caused link failures of the programs > test-binary-io, test-lseek, test-open, test-stat-time on mingw. > Reason: These programs need open(), which has a replacement defined in > lib/fchdir.c, which needs canonicalize_file_name() and depends on > canonicalize-lgpl. But through the above patch, the definition from > lib/canonicalize.c is used, which requires xalloc, which requires xalloc-die, > which requires error, which requires gettext-h - and the functions from > libintl > are not found. > > This should be a better fix. Jim, ok to apply? For coreutils, nothing will > change, since it uses --avoid=canonicalize-lgpl.
Pretty twisted ;-) That looks fine. Go ahead and commit/push.
