Hi Karl, * Karl Berry wrote on Mon, Feb 25, 2008 at 06:59:39PM CET: > A Texinfo contributor made use of two argz functions that are not in the > implementation in gnulib, argz_add and argz_count. As a result, of > course compilation failed on non-glibc systems. They seemed trivial to > implement, so here is a patch for argz.c and argz_.h. How does it look?
Good, except that I'd prefer if argz_count used strlen instead of walking the argz vector manually. Little point in adding a suboptimal algorithm if one can have speed (or smaller size) for free by using a library function. > Actually, the whole argz_.h vs argz.in.h thing is a bit confusing. It > seems like gnulib uses argz.in.h, but the libtool sources use argz_.h. > I guess I should change the name when syncing from libtool to gnulib? > Or maybe change the name in libtool? I'll change the name in Libtool after 2.2. Maybe I'll even change it to use gnulib-tool ... > P.S. I see in passing there are more argz functions not present, but > since I didn't need them, I didn't do anything about them. The code > from libc/string/argz* could perhaps be used if the need ever arises. Certainly. Cheers, Ralf
