Hi Ben, Well done!
> Finally, I noticed a nit in that test-trunc2 and test-truncf2 use > %a in fprintf, a C99 feature, but do not depend on fprintf-posix. > I did add that dependency to round-tests and roundf-tests. Oops, you're right. Done also for ceilf-tests, floorf-tests, trunc[f]-tests. In m4/round.m4, the test whether floor() is available without libm is useful for any uses of floor(). I'm therefore putting it into a separate module 'floor' which you can then depend on. In m4/roundf.m4 you need an AC_REQUIRE([gl_FUNC_FLOORF]), so that the determination of FLOORF_LIBM comes before it is used in the assignment to ROUNDF_LIBM, not afterwards. Likewise for m4/roundl.m4. In tests/test-round2.c the include of <assert.h> is not necessary. tests/test-round2.c seems to have a tab/whitespace indentation problem. Apply sed -e 's,^ , ,' In tests/test-round2.c, midbits is a constant. I would move it into the loop (also since it's confusingly named: lowbits is the low bits of janus.i. highbits is the high bits of janus.i. But the middle bits of janus.i are not midbits but either midbits or 0.) > I've been short on time to work on free software projects over > the last week, but I've now implemented these suggestions. No need to say excuses. Many of us here have a day job or can be temporarily unavailable. I'm thankful to you, because you added many improvements to the template that I gave with 'trunc'. > my m4 code can use some looking over. I haven't looked over this part; I trust that you have looked at the expansion in the configure file. Bruno
