Simon Josefsson wrote: > I noticed this for the dummy.c module, which after been imported with > --lgpl said: > > This program is free software: you can redistribute it and/or modify > it under the terms of the GNU Lesser General Public License as published by > the Free Software Foundation; either version 3 of the License, or > (at your option) any later version. > > The dummy.c in gnulib contains the GPLv3 header, and the modules file > says LGPLv2+. > > The patch below fixes this, but I'm not sure if there are other > unintended consequences. Comments? Ok to install?
The patch is not ok: it would also change LGPLv3+ files to LGPLv2+ without checking that it is allowed to do this. This is old code, meant to change a GPLv2+ to LGPLv2+. In the current situation (where we care about the distinction between LGPLv2+ and LGPLv3+ but where GPL means GPLv3+ always), what is needed is that the option --lgpl takes an argument: --lgpl=2 means to convert to LGPLv2+, whereas --lgpl or --lgpl=3 means to convert to LGPLv3+. Pieces of gnulib-tool affected: command line parsing, usage message, reading and writing of the configuration, sed_transform_lib_file, verification of license (lines 2210..2220). Bruno