Re: gettext clobbers errno (was: Re: Fwd: Re: error.c: "Unknown system error" should report errno value)

[Martin Koeppe]

Hi Bruno,
On Sun, 14 Oct 2007, Bruno Haible wrote:

Martin Koeppe wrote:
I just found the bug in gettext causing this trouble. Unfortunately I
didn't find a gettext mailing list.

For most GNU programs, you find the bug reporting address at the end of
the "<program> --help" output. "gettext --help" is in this category.

Thanks. Unfortunately, this
http://lists.gnu.org/archive/html/bug-gnu-gettext/
is not a valid URL (404). And I looked on
http://lists.gnu.org/archive/html/
for "gettext" or "intl" and couldn't find either.


Gettext is 0.16.1, file dcigettext.c, function libintl_dcigettext()

Apparently, on interix tfind() on line 584 changes errno, before it
is saved in line 587. So the patch below should be applied.

Thank you for this analysis! I'm applying this patch.

--- 595,605 ----
        retval = (char *) (*foundp)->translation;

       gl_rwlock_unlock (_nl_state_lock);
+       errno = saved_errno;

Thanks for adding this. For consistency with the rest of the file it 
should be written as:
   __set_errno (saved_errno);


Martin