"Sergey Poznyakoff" <[EMAIL PROTECTED]> writes:

>    case $file in
>    */INSTALL) dst=INSTALL;;
> -  *) dst=$file;;
> +  *) dst=$build_aux/`expr $file : 'build-aux/\(.*\)'`;;
>    esac
>    symlink_to_gnulib $file $dst || exit

I'd feel a bit better if expr was called only for file names beginning
with build-aux/ and if expr quoted its file argument.  Something like
this:

  case $file in
  */INSTALL) dst=INSTALL;;
  build-aux/*) dst=$build_aux/`expr "$file" : 'build-aux/\(.*\)'`;;
  *) dst=$file;;
  esac

Other than that, it looks fine to me; please install.  And thanks.


Reply via email to