Ben Pfaff wrote: > Building a program that imports iconv_open with builddir != > srcdir fails due to lack of $(srcdir) in the Makefile fragment.
Oops, you're right. > OK to commit the following? > > --- gnulib/modules/iconv_open.~1.1.~ 2007-03-31 14:00:19.000000000 -0700 > +++ gnulib/modules/iconv_open 2007-04-03 16:49:40.000000000 -0700 > @@ -36,17 +36,17 @@ iconv.h: iconv_.h > MOSTLYCLEANFILES += iconv.h iconv.h-t > > GPERF = gperf > -iconv_open-aix.h: iconv_open-aix.gperf > - $(GPERF) -m 10 iconv_open-aix.gperf > [EMAIL PROTECTED] > +iconv_open-aix.h: $(srcdir)/iconv_open-aix.gperf > + $(GPERF) -m 10 $(srcdir)/iconv_open-aix.gperf > [EMAIL PROTECTED] > mv [EMAIL PROTECTED] $@ The modification of the dependency line is not needed: We rely on VPATH for 'make' to find the location of the dependencies. The modification of the statement line is good. Please apply it. Bruno