Ralf Wildenhues <[EMAIL PROTECTED]> writes: >> Have we decided that gnulib files don't need HAVE_CONFIG_H checks? If >> so, maybe something should be added to the gnulib manual... > > IIRC there has been no decision to do so. Just a new module config-h > which you can use. The only point of this was that in the ALL test > (which tests almost all modules together), obviously the config-h module > is used, so -DHAVE_CONFIG_H does not get passed, so the modules that > guard config.h inclusion do break.
Ah, I understand. > I did not mean to imply that the files above need to be "fixed" in any > way. Sorry, I stated that wrong in my previous post. All I meant to > imply was that with the megatest/ALL directory, you have to manually add > -DHAVE_CONFIG_H to the DEFS variable in the Makefile to get everything > to build. > > Maybe there should be a way to automatize the "disable the config-h > module as long as one of the modules this package uses still guards > config.h"; or simpler: exempt the config-h module from the ALL test > for now. Or the megatest could add -DHAVE_CONFIG_H manually? Is there any harm in doing that? /Simon
