Paul Eggert <[EMAIL PROTECTED]> wrote: > I am changing coreutils so that it will use gnulib-tool. As the first > part of this project I'm installing the following changes into gnulib. > I've tried to keep the changes "minimal", but that's a relative term > when talking about a change of this magnitude. Please let me know if
:) > it causes problems. > > Soon I'd like to fix the AC_LIBSOURCES problem that has been remarked > upon several times on this list, e.g., "AC_LIBSOURCES considered harmful" > <http://lists.gnu.org/archive/html/bug-gnulib/2005-09/msg00030.html>. > Is this as simple as removing the AC_SOURCES lines in the .m4 files, > and replacing them with Files: lines in the modules file, or is there > something more complicated than that? Right. That's all that's needed. > 2006-08-20 Paul Eggert <[EMAIL PROTECTED]> > > Add and change modules to make it easier for coreutils to use > gnulib-tool. Awesome! That looks very good. Thanks for breaking out all the new modules. I found that openat.c includes lstat.h, but nothing in the module pulls in that file. So I checked in this change: * modules/openat (Depends-on): Add lstat. Alphabetize. Index: modules/openat =================================================================== RCS file: /sources/gnulib/gnulib/modules/openat,v retrieving revision 1.9 diff -u -r1.9 openat --- modules/openat 19 Aug 2006 22:17:01 -0000 1.9 +++ modules/openat 21 Aug 2006 07:26:59 -0000 @@ -12,11 +12,12 @@ m4/openat.m4 Depends-on: -save-cwd gettext-h dirname extensions +lstat intprops +save-cwd configure.ac: gl_FUNC_OPENAT
