-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 According to Ralf Wildenhues on 7/6/2006 2:51 PM: > > 1) $destdir may not contain slashes: gnulib-tool does `mkdir "$destdir"' > to create it, and `cd "$destdir"; $cmds; cd ..' to enter/exit.
That also could run into problems if CDPATH is defined and does not start with . > + case $destdir in > + */*) func_fatal_error "argument to --dir may not contain slashes" ;; > + esac Should we also limit \? > 4) Documentation should not be copied into the source tree (bug in > getdate module; I'm inferring from other modules here) or the > gnulib-tool should 'mkdir doc' to avoid a cp failure. OK? I would rather that documentation did get copied; but that sounds like we need a --doc-base option to gnulib-tool. Then it would be up to the package maintainer whether they added @include getdate.texi to their documentation. > > > 6) I'd like a megatest that does not test each individual module but > just all of them (I may be patient, but not _that_ patient ;-). > Also I'd like failed checks to make the thingy fail, and configure to > use a cache file whenever possible (due to the fact that the tests/ > directory uses a separate configure script, this is a large speedup). I agree with the cache idea (we have had several caching bugs in the past), as well as the quitting on failure. > > 9) Autoconf-2.60's AC_CHECK_DECLS_ONCE has two semantic differences > with the one from onceonly_2_57.m4: > - it accepts only one argument (why BTW? This looks like a bug; > I think it's been discussed here before, but don't remember the > details): Actually, autoconf's version takes a comma-separated list. I think the intent was to allow checking for something like struct foo, which contains space. But the workaround compatible to both 2.59 and 2.60 was indeed breaking the checks into multiple lines, one decl per check. - -- Life is short - so eat dessert first! Eric Blake [EMAIL PROTECTED] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2.1 (Cygwin) Comment: Public key at home.comcast.net/~ericblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFErbT084KuGfSFAYARAgQgAKDTD9yC6bFTrxIjnyOW2eVG6AjO+wCgsrUw 2+mjXuUx2ESLPRI6B3KOmmU= =qQ7W -----END PGP SIGNATURE-----
