Hello Eric, Bruno,
* Eric Blake wrote on Thu, Jul 06, 2006 at 02:25:38PM CEST:
> According to Ralf Wildenhues on 7/6/2006 1:48 AM:
> > * Paul Eggert wrote on Thu, Jul 06, 2006 at 01:44:03AM CEST:
> >> - while ((c = getc (stream)) != EOF && ISSPACE (c))
> >> + while ((c = getc (stream)) != EOF && isspace (c))
> >
> > missing cast to unsigned char (c is int).
>
> getc is guaranteed to return an int that is in the range acceptable by
> isspace. No cast needed here, if I understand correctly.
Oh yes, right. Thanks for correcting me on this, also to Bruno. So the
remaining issue would be fixed by the patch below. I've applied that.
Cheers,
Ralf
* strtod.c (strtod): cast the argument of tolower to unsigned char.
Index: lib/strtod.c
===================================================================
RCS file: /cvsroot/gnulib/gnulib/lib/strtod.c,v
retrieving revision 1.20
diff -u -r1.20 strtod.c
--- lib/strtod.c 5 Jul 2006 23:35:19 -0000 1.20
+++ lib/strtod.c 6 Jul 2006 17:23:11 -0000
@@ -101,7 +101,7 @@
if (!got_digit)
goto noconv;
- if (tolower (*s) == 'e')
+ if (tolower ((unsigned char) *s) == 'e')
{
/* Get the exponent specified after the `e' or `E'. */
int save = errno;
