Bruno Haible <[EMAIL PROTECTED]> writes: > Paul, what about the following patch to make our replacement > functions MT-safe?
Thanks, but in this particular case I'd like to know more before saying yes. I don't know of any hosts that have multithreading and localtime but lack a working localtime_r. The problems that I know of in this area typically are namespace problems, where the system has a localtime_r but refuses to let you see it unless you utter the appropriate mumbojumbo. In this case I'd prefer the bug to be exposed to the installer (so that they can use the appropriate compiler flags), rather than worked-around with a replacement involving a global lock, since the system's localtime_r undoubtedly will be better than our replacement. If there's a specific system where this global-lock workaround is actually needed then it's a good idea to put in, but I'd like to see the details, and if possible have the workaround installed only when it's actually needed.
