-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Bruno Haible <[EMAIL PROTECTED]> writes:
> Paul Eggert wrote on 2005-11-15: > > I'd like Bruno's opinion on all this before installing into gnulib. > > > > 2005-11-14 Paul Eggert <[EMAIL PROTECTED]> > > > > * lib/stdint_.h (intmax_t) [defined intmax_t]: Do not declare. > > (uintmax_t) [defined uintmax_t]: Do not declare. > > (SIZE_MAX) [defined SIZE_MAX]: Do not define. > > This works around a problem if intmax_t.m4 and/or uintmax_t.m4 > > and/or size_max.m4 are also used. Problem reported by Mark D. Baushke. > > Thanks for applying this patch while I was unavailable. > > > #ifdef _STDINT_H_HAVE_INT64 > > +# ifndef intmax_t > > typedef int64_t intmax_t; > > +# endif > > +# ifndef uintmax_t > > typedef uint64_t uintmax_t; > > +# endif > > I'm worried that we arrive at a situation where > sizeof (intmax_t) != sizeof (uintmax_t), > if the configure.ac has invoked gl_AC_TYPE_INTMAX_T but not > gl_AC_TYPE_UINTMAX_T or vice versa. I can see two solutions: > a) Have gl_STDINT_H require gl_AC_TYPE_INTMAX_T and gl_AC_TYPE_UINTMAX_T. > b) Merge gl_AC_TYPE_INTMAX_T and gl_AC_TYPE_UINTMAX_T into a single macro > that defines intmax_t and uintmax_t simultaneously. > Which one is better? I believe a merge of the two types is cleaner with gl_STDINT_H to require this new macro. -- Mark -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.3 (FreeBSD) iD8DBQFDwrL8Cg7APGsDnFERAu7DAKCY4b4AE0yUDMdaAS/r/PNNlOUD9ACfbkRh FmaXH+d4qB/XCO0z1lzqV9w= =rRrL -----END PGP SIGNATURE----- _______________________________________________ bug-gnulib mailing list bug-gnulib@gnu.org http://lists.gnu.org/mailman/listinfo/bug-gnulib