Jim Meyering <[EMAIL PROTECTED]> writes:
> This came up when I tried to print an xtime_nsec value with the
> same format (%ld) that I'd use to print timespec.tv_nsec member.
OK, thanks, then I guess it's better to be consistent with POSIX. I
installed the patch you sent, with one more int->long change, into
both gnulib and coreutils. Here's what I installed.
2006-01-03 Paul Eggert <[EMAIL PROTECTED]>
* xtime.h (xtime_make, xtime_nonnegative_nsec, xtime_nsec): Use
long int, not int, for nanosecond counts, so that people who are
used to POSIX struct timespec won't be surprised. Reported by Jim
Meyering.
--- xtime.h.~1.4.~ 2005-09-29 09:51:24.000000000 -0700
+++ xtime.h 2006-01-03 15:17:54.000000000 -0800
@@ -1,6 +1,6 @@
/* xtime -- extended-resolution integer time stamps
- Copyright (C) 2005 Free Software Foundation, Inc.
+ Copyright (C) 2005, 2006 Free Software Foundation, Inc.
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
@@ -41,7 +41,7 @@ typedef long int xtime_t;
/* Return an extended time value that contains S seconds and NS
nanoseconds, without any overflow checking. */
static inline xtime_t
-xtime_make (xtime_t s, int ns)
+xtime_make (xtime_t s, long int ns)
{
if (XTIME_PRECISION == 1)
return s;
@@ -68,17 +68,17 @@ xtime_sec (xtime_t t)
}
/* Return the number of nanoseconds in T, which must be nonnegative. */
-static inline int
+static inline long int
xtime_nonnegative_nsec (xtime_t t)
{
return t % XTIME_PRECISION;
}
/* Return the number of nanoseconds in T. */
-static inline int
+static inline long int
xtime_nsec (xtime_t t)
{
- int ns = t % XTIME_PRECISION;
+ long int ns = t % XTIME_PRECISION;
if (ns < 0)
ns += XTIME_PRECISION;
return ns;
_______________________________________________
bug-gnulib mailing list
bug-gnulib@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-gnulib
