Simon Josefsson wrote:
> Ok to install?

> +/* Compute CRC-32 value of LEN bytes long BUF, and return it. */
> +extern unsigned long crc32 (char *buf, size_t len);
> ...

All 4 functions don't write into buf, therefore the 'buf' argument type should
be 'const char *', not 'char *'.

> +   Due to historic implementatio errrs, this variant is sometimes used
> ...
> +   initial and final XOR operation.  Due to historic implementatio
> +   errrs, this variant is sometimes used (i.e., in RFC 3961).  */

4 typos in comments.

Bruno



_______________________________________________
bug-gnulib mailing list
bug-gnulib@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-gnulib
  • Re: [bug-gnulib] crc Bruno Haible

Reply via email to