Simon Josefsson <[EMAIL PROTECTED]> writes:
> I am not sure about the prototype. Should it use 'char*'? 'int*'?
If its name is mem* then it should use void *, for consistency.
The current implementation uses 'restrict', so memxor.m4 should
AC_REQUIRE([gl_C_RESTRICT]) and the memxor module should depend on the
restrict module.
The current implementation casts 'const void *' to 'char *', which
will provoke warnings with many compilers. Also, it contains
unnecessary casts. How about this implementation instead?
char *d = dest;
char const *s = src;
for (; n > 0; n--)
*d++ ^= *s++;
return dest;
_______________________________________________
bug-gnulib mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/bug-gnulib
