Hello,

replying to an older thread:

On Wed, Jun 08, 2005 at 10:50:07PM +0100, James Youngman wrote:
>       if unset TIME_STYLE 2>/dev/null ...
>       else
>               TIME_STYLE=posix-"$TIME_STYLE"

I think this is too complicated.

The documentation says the default is posix-long-iso, and as it is
posix-*, it should give us the traditional behaviour for the POSIX
locale (which was just set).

Alexandre, would you accept the patch as attached to this mail?

Happy hacking,
Stepan
2005-06-28  Stepan Kasal  <[EMAIL PROTECTED]>

        * lib/mdate-sh: Avoid infinite loop with GNU ls when TIME_STYLE is set.
        Diagnosis by Vincent Lefevre, reported by James Youngman.

Index: lib/mdate-sh
===================================================================
RCS file: /cvs/automake/automake/lib/mdate-sh,v
retrieving revision 1.17
diff -u -r1.17 mdate-sh
--- lib/mdate-sh        14 May 2005 20:28:50 -0000      1.17
+++ lib/mdate-sh        28 Jun 2005 12:16:12 -0000
@@ -59,6 +59,12 @@
 LC_TIME=C
 export LC_TIME
 
+# GNU ls changes its time format in response to the TIME_STYLE variable, but
+# we cannot unset it since the V7 shell did not have an "unset" command.
+# The documentation says that the default is "posix-long-iso".
+#
+test "${TIME_STYLE+set}" = set && TIME_STYLE=posix-long-iso
+
 save_arg1="$1"
 
 # Find out how to get the extended ls output of a file or directory.
_______________________________________________
Bug-findutils mailing list
Bug-findutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-findutils

Reply via email to