On Sun, May 29, 2005 at 11:11:52PM +0200, Bas van Gompel wrote:
> Here is a patch which will cause locate to read every database only
> once. This will cause a functional change: When using multiple
> databases /and/ multiple patterns, the order in which results are
> output changes from {d1p1, d2p1, d1p2, d2p2} to {d1p1, d1p2, d2p1,
> d2p2}. Also, --statistics can be combined with patterns to get
> statistics on the matches, and --print (-p) can be used to output names
> when they otherwise would not (because of -S/-c).
A well-constructed patch, many thanks! I have applied it. In the
future, when making a user-visible change, could you add a comment in
the NEWS file describing the impact of the change? Thanks.
Lastly, do you think there is scope for removing process_simple()
entirely? Special-casing argc <= 1 by having a dedicated function
seems a little inelegant.
Regards,
James.
_______________________________________________
Bug-findutils mailing list
Bug-findutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-findutils
