Hi,

cfagent of cfengine-2.2.3 can access cfargv[argc] in

| for (i = 1, j = 1; i < argc; i++)
| ...
| cfargv[j] = NULL;

but allocates only

| malloc(sizeof(char *) * cfargc + 1);

bytes. Attached patch fixes this.



Enrico
2008-01-21  Enrico Scholz  <[EMAIL PROTECTED]>
	* src/cfagent.c: fixed missing parenthesis in allocating memory
	  for cfargv[]

diff -up cfengine-2.2.3/src/cfagent.c.~1~ cfengine-2.2.3/src/cfagent.c
--- cfengine-2.2.3/src/cfagent.c.~1~	2007-12-01 13:48:07.000000000 +0100
+++ cfengine-2.2.3/src/cfagent.c	2008-01-16 15:19:46.000000000 +0100
@@ -321,7 +321,7 @@ for (i = 1, j = 1; i < argc; i++)
 
 /* Allocate memory for cfargv. */
 
-cfargv = (char **) malloc(sizeof(char *) * cfargc + 1);
+cfargv = (char **) malloc(sizeof(char *) * (cfargc + 1));
 
 if (!cfargv)
    {
_______________________________________________
Bug-cfengine mailing list
[email protected]
https://cfengine.org/mailman/listinfo/bug-cfengine

Reply via email to