On Jul 30, 2007, at 5:32 PM, Jo Rhett wrote:
Ignore this and my missing attachment. Eric will be sending a revised one.
Here it is (attached). This revises the Portage package installation, and fixes to small other bugs in BuildCommandLine.
A few remarks:- Verbose("BuildCommandLine(): Processing package %s at location %d. \n", package->name, &package ); + Verbose("BuildCommandLine(): Processing package %s at location %u. \n", package->name, &package );
This changes the printf placeholder from %d (decimal) to %u (unsigned). This keeps the addresses printed out positive, since memory addresses aren't signed.
+ ++cmd_args;I put some code in place in my patch ``More buffer overflow fun'' to prevent passing too many arguments to cfpopen in BuildCommandLine, but neglected to increment the argument counter that was keeping track of this.
The rest only modifies code in PortagePackageCheck. -- Eric Searcy OSU Open Source Lab
portage.patch
Description: Binary data
PGP.sig
Description: This is a digitally signed message part
_______________________________________________ Bug-cfengine mailing list [email protected] https://cfengine.org/mailman/listinfo/bug-cfengine
