https://sourceware.org/bugzilla/show_bug.cgi?id=33437

            Bug ID: 33437
           Summary: libsframe test names are not unique
           Product: binutils
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libsframe
          Assignee: indu.bhagat at oracle dot com
          Reporter: rearnsha at sourceware dot org
  Target Milestone: ---

If the libsframe tests are compared against a previous run using the latest
version of GCC's compare_tests script, it reports the following issue:

Non-unique test names: (Eeek!)
      2 PASS: aarch64-qemu: libsframe: encode-1: Encoder FDE count
      2 PASS: aarch64-qemu: libsframe: findfre-1: Adding FDE1
      2 PASS: aarch64-qemu: libsframe: findfre-1: Adding FDE2
      2 PASS: aarch64-qemu: libsframe: findfre-1: Decoder setup
      2 PASS: aarch64-qemu: libsframe: findfre-1: Encoder write
      2 PASS: aarch64-qemu: libsframe: findfre-1: Find FRE for last PC covered
by FRE
      2 PASS: aarch64-qemu: libsframe: findfre-1: Find FRE for out of range PC
      2 PASS: aarch64-qemu: libsframe: findfre-1: Find first FRE
      2 PASS: aarch64-qemu: libsframe: findfre-1: Find last FRE
      2 PASS: aarch64-qemu: libsframe: findfre-1: Find second FRE
      2 PASS: aarch64-qemu: libsframe: findfre-1: Find third FRE
      2 PASS: aarch64-qemu: libsframe: findfre-1: Test FDE count
      2 PASS: aarch64-qemu: libsframe: findfunc-1: Adding FDE1
      2 PASS: aarch64-qemu: libsframe: findfunc-1: Adding FDE2
      2 PASS: aarch64-qemu: libsframe: findfunc-1: Adding FDE3
      2 PASS: aarch64-qemu: libsframe: findfunc-1: Decoder setup
      2 PASS: aarch64-qemu: libsframe: findfunc-1: Encoder write
      2 PASS: aarch64-qemu: libsframe: findfunc-1: Find FRE in FDE1
      2 PASS: aarch64-qemu: libsframe: findfunc-1: Find FRE in FDE2
      2 PASS: aarch64-qemu: libsframe: findfunc-1: Find FRE in FDE3
      2 PASS: aarch64-qemu: libsframe: findfunc-1: Test FDE count
      2 PASS: aarch64-qemu: libsframe: findfunc-1: test-1: Find FRE for PC not
in range
      2 PASS: aarch64-qemu: libsframe: findfunc-1: test-2: Find FRE for PC not
in range
      2 PASS: aarch64-qemu: libsframe: findfunc-1: test-3: Find FRE for PC not
in range
      2 PASS: aarch64-qemu: libsframe: findfunc-1: test-4: Find FRE for PC not
in range
      2 PASS: aarch64-qemu: libsframe: frecnt-2: Decode get FDE
      2 PASS: aarch64-qemu: libsframe: frecnt-2: Decode get FRE
      2 PASS: aarch64-qemu: libsframe: plt-findfre-1: Adding FDE1 for plt
      2 PASS: aarch64-qemu: libsframe: plt-findfre-1: Decoder setup
      2 PASS: aarch64-qemu: libsframe: plt-findfre-1: Encoder write
      2 PASS: aarch64-qemu: libsframe: plt-findfre-1: Find first FRE in PLT1
      2 PASS: aarch64-qemu: libsframe: plt-findfre-1: Find first FRE in PLT4
      2 PASS: aarch64-qemu: libsframe: plt-findfre-1: Find last FRE in PLT1
      2 PASS: aarch64-qemu: libsframe: plt-findfre-1: Find last FRE in PLT4
      2 PASS: aarch64-qemu: libsframe: plt-findfre-1: Find no FRE for out of
range PLT6
      2 PASS: aarch64-qemu: libsframe: plt-findfre-1: Find second FRE in PLT1
      2 PASS: aarch64-qemu: libsframe: plt-findfre-1: Find second FRE in PLT4
      2 PASS: aarch64-qemu: libsframe: plt-findfre-1: Test FDE count

This is because the tests are run with different options, but the test names do
not reflect the change.  The logs contain, for example:

PASS: findfre-1: Find third FRE
PASS: findfre-1: Find third FRE

testnames should be unique so that we can never get into the situation where we
see

PASS: findfre-1: Find third FRE
FAIL: findfre-1: Find third FRE

as this leads to ambiguity when trying to identify which permutation failed
when comparing the summary files.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

Reply via email to