https://sourceware.org/bugzilla/show_bug.cgi?id=32001
Nelson Chu <nelsonc1225 at sourceware dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |nelsonc1225 at sourceware dot
org
--- Comment #1 from Nelson Chu <nelsonc1225 at sourceware dot org> ---
Since the riscv_update_subset1 is shared by .option arch and
riscv_implicit_subsets table, the previous one is for normal users, and the
later one is for developers.
When developing, I added the following wrong code,
diff --git a/bfd/elfxx-riscv.c b/bfd/elfxx-riscv.c
index b3adbed1913..2e9e42c4b62 100644
--- a/bfd/elfxx-riscv.c
+++ b/bfd/elfxx-riscv.c
@@ -1269,6 +1269,7 @@ static struct riscv_implicit_subset
riscv_implicit_subsets[] =
{"svade", "+zicsr", check_implicit_always},
{"svadu", "+zicsr", check_implicit_always},
{"svbare", "+zicsr", check_implicit_always},
+ {"i", "+unknown_implicit", check_implicit_always},
{NULL, NULL, NULL}
};
When user added the wrong user assembly,
% cat tmp.s
.option arch, +unknown_arch
%
~/work/build-upstream/build-elf64-upstream/build-install/bin/riscv64-unknown-elf-as
tmp.s -o tmp.o
Assembler messages:
Error: internal: unknown ISA extension `unknown_implicit' in
riscv_implicit_subsets `+unknown_implicit'
tmp.s:1: Error: unknown ISA extension `unknown_arch' in .option arch
`+unknown_arch'
The two errors seems reasonable to me, so what error messages that you think
should be correct? Thanks.
--
You are receiving this mail because:
You are on the CC list for the bug.
