https://sourceware.org/bugzilla/show_bug.cgi?id=30354

Nick Clifton <nickc at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #11 from Nick Clifton <nickc at redhat dot com> ---
(In reply to Torbjörn SVENSSON from comment #9)
Hi Torbjörn

> >                       if (!cmse_sec->gc_mark
> >                           && !_bfd_elf_gc_mark (info, cmse_sec, 
> > gc_mark_hook))
> >                         return false;
> >                       /* The debug sections related to these secure entry
> >                          functions are marked on enabling below flag.  */
> >                       debug_sec_need_to_be_marked = true;
> >                       break;
> Is it correct to break the for-loop here?
> When the break statement is there, then only the first entry in the
> sym_hashes array that matches the CMSE_PREFIX criteria will passed on to the
> _bfd_elf_gc_mark function. Isn't it required to call this function for every
> cmse_sec value or would it be enough with just the first value?

You are correct.  That was another mistake.  I have fixed that too and checked
in the patch.

Cheers
  Nick

-- 
You are receiving this mail because:
You are on the CC list for the bug.

Reply via email to