https://sourceware.org/bugzilla/show_bug.cgi?id=25713

--- Comment #36 from Fred Eisele <fredrick.eisele at gmail dot com> ---
The patch does not include:

* handling files of the for '*.o' any differently
* does not check that the filename contains only valid characters
* there are two callocs 

I presume the filename has been checked for correct form and content before
this function is called.
I think the two callocs are reasonable. It would be relatively easy to have a
couple of buffers on the stack that would normally be used with the callocs
only being used when the size of the buffers is exceeded. That would add more
complexity that I do not feel is worth the benefit.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

Reply via email to