Ah, my apologies, I will be sure to do that in the future.

Thanks very much for applying the patch!
Joel

On Wed, Jun 3, 2020 at 11:47 AM Nick Clifton <ni...@redhat.com> wrote:

> Hi Joel,
>
> > I did not see anything in the current bug list for windmc that covers
> this, but fortunately the solution seems straightforward. I have attached a
> patch with a minimal fix. The changes make the typecasting logic match
> mc.exe. I will be happy to make any other requested adjustments as well.
>
> Thanks very much for reporting this bug - and supplying a patch to fix it.
> :-)
>
> I have gone ahead and applied the patch along with the changelog entry
> below.
>
> In the future, if you do run across further bugs with the binutils, would
> you
> mind reporting them using the binutils bugzilla system[1] ?  It just makes
> them
> easier to track and ensure that they get fixed.
>
> Cheers
>   Nick
>
> [1] https://sourceware.org/bugzilla/enter_bug.cgi?product=binutils
>
> binutils/ChangeLog
> 2020-06-03  Joel Anderson  <joelanderson...@gmail.com>
>
>         * windmc.h (struct mc_node): Add id_typecast field.
>         * mcparse.y (message): Initialise the id_typecast field.
>         * windmc.c (write_dbg): Use the id_typecast field as a parameter
>         when calling write_dbg_define.
>         (write_header): Likewise.
>
>

Reply via email to