https://sourceware.org/bugzilla/show_bug.cgi?id=25803
--- Comment #30 from Nick Clifton <nickc at redhat dot com> --- (In reply to gagan singh sidhu (gagz, broly, w/e u want) from comment #29) > i saw your commit and while it’s not wrong, i was hoping you would be open > to suggestions: > > 1. we don’t need both the changes to elfxx-mips.c and obj-elf.c. > -the change to obj-elf.c will avoid us ever having the situation again > in > elfxx-mips.c > > so in terms of a minimalist aspect, i was hoping you would pick whichever > change you wanted, and disregard the other. > -the whole “less changes is a good thing” paradigm Except that in this case we are fixing two bugs. The first was that the linker was not providing a helpful error message that would allow the user to investigate the problem with their link. Ie if the linker had provided the name(s) of the invalid symbols when this problem first arose then someone may have worked out that the issue was ifunc symbols a long time ago. Hence I think that keeping the change to elfxx-mips.c is a good idea. The change to obj-elf.c fixes the underlying problem, hence it needs to remain. But being more helpful to users is always a good thing, so I am going to leave both patches in. -- You are receiving this mail because: You are on the CC list for the bug.
