http://sourceware.org/bugzilla/show_bug.cgi?id=15295
Nick Clifton <nickc at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |nickc at redhat dot com
--- Comment #4 from Nick Clifton <nickc at redhat dot com> 2013-03-26 14:23:29
UTC ---
Hi Jim,
Sorry about the fread() snafu - thanks for spotting it.
You only uploaded the oggenc.c source file, not the offldr source file, so I
was only able to run checks using that. On my system (x86 not s390) I see
results like this:
% strace -c ../gas/as-new -o oggenc.o -alshd=oggenc.lst oggenc.s
% time seconds usecs/call calls errors syscall
------ ----------- ----------- --------- --------- ----------------
62.59 0.005000 385 13 close
25.04 0.002000 56 36 23 open
8.91 0.000712 712 1 unlink
1.94 0.000155 0 3001 write
0.61 0.000049 0 1484 brk
0.35 0.000028 0 1064 read
0.33 0.000026 9 3 mprotect
0.23 0.000018 0 37 _llseek
0.00 0.000000 0 1 execve
0.00 0.000000 0 1 1 access
0.00 0.000000 0 1 getrusage
0.00 0.000000 0 11 munmap
0.00 0.000000 0 26 mmap2
0.00 0.000000 0 17 15 stat64
0.00 0.000000 0 1 lstat64
0.00 0.000000 0 13 fstat64
0.00 0.000000 0 2 fcntl64
0.00 0.000000 0 1 set_thread_area
------ ----------- ----------- --------- --------- ----------------
100.00 0.007988 5713 39 total
Which looks pretty good to me - almost no lseek's and the reads and writes look
reasonable too. The times look OK too:
% time ../gas/as-new -o oggenc.o -alshd=oggenc.lst oggenc.s
Time spent in user mode (CPU seconds) : 1.756
Total time (wall clock seconds) : 0:01.91
CPU utilisation (CPU time/wall time) : 99.4%
Maximum memory use (kilobytes) : 33646
So I have gone ahead and checked in the patch (with the fread correction).
Please could you check to see if the patched sources still show a large number
of lseek's and if they do, and you are allowed to, please upload the offldr
source so that I can investigate further.
Cheers
Nick
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils
