http://sourceware.org/bugzilla/show_bug.cgi?id=15200
--- Comment #22 from pete <petechou at gmail dot com> 2013-03-25 03:56:32 UTC
---
(In reply to comment #21)
> I don't see why either of your suggested changes would be correct.
>
> Would you mind trying my patch, the second one in comment #13, to see if it
> fixes your problem?
Yes, it can define the symbols correctly.
>
> Thanks.
Is the in_reg() checking for the reference in regular object? If so, will it be
more clear if we can check it first? like
if (oldsym == NULL || !oldsym->in_reg())
return NULL;
if (oldsym->source() != Symbol::IS_UNDEFINED &&
!oldsym->is_from_dynobj())
return NULL;
Well, this is only my opinion.
Another question about the only_if_ref flag. Is it for the reference in regular
object? Looks like both reg/dyn symbols will go into the namepool, but we don't
check in_reg() previously.
Thanks.
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
bug-binutils mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/bug-binutils
