http://sourceware.org/bugzilla/show_bug.cgi?id=14813
Bug #: 14813
Summary: Wrong return type for opncls_bclose
Product: binutils
Version: unspecified
Status: NEW
Severity: normal
Priority: P2
Component: binutils
AssignedTo: unassig...@sourceware.org
ReportedBy: hjl.to...@gmail.com
Classification: Unclassified
There are
static int
opncls_bclose (struct bfd *abfd)
{
struct opncls *vec = (struct opncls *) abfd->iostream;
/* Since the VEC's memory is bound to the bfd deleting the bfd will
free it. */
int status = 0;
if (vec->close != NULL)
status = (vec->close) (abfd, vec->stream);
abfd->iostream = NULL;
return status;
}
bfd_boolean
bfd_close (bfd *abfd)
{
bfd_boolean ret;
if (bfd_write_p (abfd))
{
if (! BFD_SEND_FMT (abfd, _bfd_write_contents, (abfd)))
return FALSE;
}
if (! BFD_SEND (abfd, _close_and_cleanup, (abfd)))
return FALSE;
ret = abfd->iovec->bclose (abfd);
if (ret)
_maybe_make_executable (abfd);
_bfd_delete_bfd (abfd);
return ret;
}
opncls_bclose returns 0 on success, which is FALSE in bfd_boolean.
As the result, bfd_close returns FALSE on success.
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils
