------- Additional Comments From nickc at redhat dot com 2008-02-27 14:17
-------
Hi Denis,
I have looked over your patch and I think that it is a very good first stab at
this. There are some improvements which I think can be made however, such as:
* Adding a new command line option (eg -E) to enable this feature without
having to use the -a option. Plus the feature needs to be mentioned in
binutils/NEWS and documented in binutils/doc/binutils.texi.
* Removing the read_sleb128 code and using the read_leb128 function in dwarf.c
instead. (Of course it will have to be exported from there). You could also
delete the read_uleb128 function and replace all references to that as well...
Avoiding code duplication is a good thing IMHO.
* Please do not declare variables in the middle of a block. It is a gcc
extention and we would like the code to be able to be compiled by any ISO-C
compliant compiler.
* This code might be better as a patch to binutils/dwarf.c.
* You have to use a different printf formatter in order to print 64-bit values
on a Cygwin based system. (See other places in readelf.c where %llx is used).
[Actually this should be broken out into a separate function].
Cheers
Nick
--
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |WAITING
http://sourceware.org/bugzilla/show_bug.cgi?id=4907
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
_______________________________________________
bug-binutils mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/bug-binutils
