------- Additional Comments From nickc at redhat dot com  2008-02-27 12:39 
-------
Hi Markus,
  Thanks for the patch - it works, but it introduces new failures into the gas
h8300 specific tests because it changes the default encoding for that
instruction.  (To the version without the top bit set in the 4th byte).  A
simpler fix is to just add a new line to the h8_opcodes table to accept the
encoding without the top bit set, but leaving in the current (top bit is set)
line.  That way gas does not change its behaviour, but objdump can disassemble
both versions.

  The uploaded patch does this, and it adds a new test to the gas testsuite in
order to make sure that the bug does not reoccur.  I will check this patch in
along with the following changelog entry.

Cheers
  Nick

include/opcode/ChangeLog
2008-02-27  Markus Gyger  <[EMAIL PROTECTED]>
            Nick Clifton  <[EMAIL PROTECTED]>

        PR 3134
        * h8300.h (h8_opcodes): Add an encoding for a mov.l instruction
        with a 32-bit displacement but without the top bit of the 4th byte
        set.    

gas/testsuite/ChangeLog
2008-02-27  Nick Clifton  <[EMAIL PROTECTED]>

        PR 3134
        * gas/h8300/pr3134.s: New test.
        * gas/h8300/pr3134.d: Expected disassembly
        * gas/h8300/h8300.exp: Run the new test.


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://sourceware.org/bugzilla/show_bug.cgi?id=3134

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


_______________________________________________
bug-binutils mailing list
bug-binutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-binutils

Reply via email to