On Thu, Aug 16, 2007 at 02:32:19PM +0930, Clytie Siddall wrote: > >1. There are some duplicate strings, varying only in whitespace. > >You may want to reduce these: they can also result in varying > >translations (I only noticed them because I was reviewing the whole > >file). > > > >(a) > >#: emultempl/armcoff.em:72 > >#, c-format > >msgid " --support-old-code Support interworking with old code\n" > > > >#: emultempl/pe.em:325 > >#, c-format > >msgid " --support-old-code Support interworking > >with old code\n"
The reason for this is that these strings are part of blocks of help text. pe has a number of fairly long options, so the descriptive text is indented rather more than that needed for armcoff. > >#: emultempl/armcoff.em:121 > >#, c-format > >msgid "Errors encountered processing file %s" > > > >#: emultempl/pe.em:1334 > >#, c-format > >msgid "Errors encountered processing file %s\n" Seems to be fixed already. > >#: ldexp.c:1054 > >#: ldexp.c:1079 > >#, c-format > >msgid "%F%S nonconstant expression for %s\n" > > > >#: ldexp.c:1138 > >#, c-format > >msgid "%F%S: nonconstant expression for %s\n" I just committed a fix on mainline for this. > >#: emultempl/armcoff.em:194 > >#: emultempl/pe.em:1533 > >msgid "%P: warning: connot find thumb start symbol %s\n" > > > >- connot > >+ cannot Ditto. > >#: ldmisc.c:245 > >#, c-format > >msgid "built in linker script:%u > > > >Should there be a space after the colon? Probably not. A similar message when using a file script is <filename>:<line_number>. > >I don't know if you want to abbreviate these as much as possible, > >or if you would prefer that they were correct English: [snip] The idea is to fit help text on an 80-column display. > >#: lexsup.c:329 > >msgid "" > >"Set DT_NEEDED tags for DT_NEEDED entries in\n" > >"\t\t\t\tfollowing dynamic libs" These messages probably shouldn't use embedded tabs. Fixed. > >I hope this is useful. Yes, thanks. > >The developer thus needs to pass the option --msgid-bugs-address=... Fixed mainline and 2.18. -- Alan Modra Australia Development Lab, IBM _______________________________________________ bug-binutils mailing list bug-binutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-binutils
