------- Additional Comments From wilson at specifix dot com 2007-03-27 01:23
-------
This looks right to me.
The bug is curious, but apparently we only handle or.andcm and and.orcm because
these are the only parallel compares that gcc is smart enough to emit. So when
we added support for these parallel compare types to gcc, we only extended gas
to handle these, and forgot to handle the others at the same time.
The code could maybe be a bit more efficient. We have 4 strstr calls, then a
conditional expression with 4 ? tests. This isn't a reason to refuse it though.
There is one important consideration here about copyright assignments. This was
originally sent from an in.ibm.com address, and then from a freenet.de address.
I need to be sure about who wrote the patch, and that they have a valid
copyright assignment. If this was written by an IBM employee, then it
presumably falls under the IBM corporate assignment.
--
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
http://sourceware.org/bugzilla/show_bug.cgi?id=3990
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
_______________________________________________
bug-binutils mailing list
bug-binutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-binutils
