------- Additional Comments From jbeulich at novell dot com  2005-04-15 12:24 
-------
I see two problems with this suggestion:
The small one is that the change to read.c isn't shown.

The larger one is that I don't think this is the right thing to do here.
tc_canonicalize_symbol_name shouldn't be called in this context at all; even for
non-zero length symbols it may do the wrong thing (for ia64 it removes trailing
# symbols), whereas file names should remain untouched. Looking at how this gets
called here, I see that save_symbol_name may do more bad to the filename (it may
strip a leading _, and may also case-convert it). So it could either be
save_symbol_name (or symbol_new) that would need to change (taking an additional
parameter to indicate it should leave alone the symbol name), or elf_file_symbol
would have to change the name of the symbol after having gone through symbol_new
(and to address the problem brought up here, it could call symbol_new blindly
with a literal string [say, "FILE"], preventing any issues with
tc_canonicalize_symbol_name).


-- 


http://sources.redhat.com/bugzilla/show_bug.cgi?id=847

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


_______________________________________________
bug-binutils mailing list
bug-binutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-binutils

Reply via email to