------- Additional Comments From wilson at specifixinc dot com 2005-03-28
21:36 -------
Subject: Re: gas should avoid F-unit NOPs (and B-unit
probably, too)
On Mon, 2005-03-28 at 13:03, hjl at lucon dot org wrote:
> This patch adds "-mtune=[itanium1|itanium2]". I will update
> NEWS and doc if it is OK.
I think the extra_goodness change is a little confusing. You are
reusing the parameter "slot" for the return value, even though the
return value has nothing to do with slot numbers. I had to read the
code twice before I figured out why you were changing the slot numbers.
I would prefer a new local variable named "goodness" or "retval" or
whatever. And then we can initialize it to a sensible value like 0. Or
perhaps just "return 2" instead of "slot = 2" like the original code
had. There is also the issue that maybe there should be a "default:
abort ();" to make sure the code gets appropriately modified when future
processors are added.
Otherwise, it all looks OK to me.
--
http://sources.redhat.com/bugzilla/show_bug.cgi?id=803
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
_______________________________________________
bug-binutils mailing list
bug-binutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-binutils
