On 10/26/24 5:04 PM, Mike Jonkmans wrote:
On Thu, Oct 24, 2024 at 03:07:46PM -0400, Grisha Levit wrote:These are reported by make --warn-undefined-variables.Most were being set previously (sometimes 20 years ago) and got left behind in recepies after their definitions have been removed. Others only get set in some configurations so it makes sense to prevent them from inheriting stray values from the environment otherwise. A few are just typos.Good cleanup! I see the Makefile has evolved in a good way. ...Makefile.in - ALLOC_FILES,GLOBC,GLOBO,LIBRARY_SOURCE: remove deprecated variablesLIBRARY_SOURCE is useful to generate tags.
Yes, and this was its original purpose, but does anyone generate tags files besides me? (And I don't do it very often.)
E.g. LIBRARY_SOURCE = $(SHLIB_SOURCE) $(READLINE_SOURCE) $(HISTORY_SOURCE) \ $(TERMCAP_SOURCE) $(GLOB_SOURCE) $(TILDE_SOURCE) \ $(MALLOC_SOURCE)
There's no reason not to include serveral of these in a declaration. The tags files should be independent of any particular configuration. -- ``The lyf so short, the craft so long to lerne.'' - Chaucer ``Ars longa, vita brevis'' - Hippocrates Chet Ramey, UTech, CWRU c...@case.edu http://tiswww.cwru.edu/~chet/
OpenPGP_signature.asc
Description: OpenPGP digital signature