On 10/18/24 12:19 PM, Grisha Levit wrote:
On Fri, Oct 18, 2024 at 12:15 PM Chet Ramey <chet.ra...@case.edu> wrote:On 10/18/24 11:51 AM, Chet Ramey wrote:On 10/17/24 8:27 PM, Grisha Levit wrote:The mmap in history_do_write would usually fail when appending because the offset must be a multiple of the page size.Thanks for the report. Not everyone requires this, but since some systems do, it's better to do this for portability.Of course, the fact that nothing defines HISTORY_USE_MMAP limits the impact somewhat.I was just composing a question about this -- is this intentional? It looks like it used to be behind HAVE_MMAP (which does get set) but changed soon after.
Probably. I can't remember -- it was over 20 years ago. My guess is I
did it as an experiment and never went back to it because performance
was acceptable.
I suppose we can try it again, since everyone has mmap with more-or-less
the same behavior now.
--
``The lyf so short, the craft so long to lerne.'' - Chaucer
``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, UTech, CWRU c...@case.edu http://tiswww.cwru.edu/~chet/
OpenPGP_signature.asc
Description: OpenPGP digital signature
