On 3/19/24 11:48 PM, Paul Eggert wrote:
On 3/18/24 12:41, Chet Ramey wrote:I'm not sure what you're using, but that was not my experience on macOS.I am using Fedora 39 (the current version) on x86-64. That could explain our differing experiences.I see several diagnostics (mostly diff output) with "make check" on Fedora 39. The diagnostics can vary from run to run, i.e., they aren't necessarily reproducible.
Interesting. I can't reproduce this. Using the commit to which your patches apply, without applying any of them, on a fresh Virtualbox Fedora 39 install, I get consistent `make tests' output every time. The diffs from the `right' output are always the same: 1. Linux has different error messages 2. Linux numbers signals differently 3. If you don't have some problem locales installed, the test suite skips tests for those locales But every time I run the test suite on Fedora 39, I get the same output.
At some point I suppose it'd be nice if 'make check' succeeded (exit status 0) or failed (nonzero exit status) so that it is easy for non-experts to tell which diagnostics matter; that's what many other packages do.
Output that differs in error message language isn't a failure.
Thanks, I checked the devel branch against what I submitted, found a few errors, and while reviewing all this found and fixed a few other integer-overflow issues in Bash. Proposed patches attached, in "git format-patch" format so you can use "git am" on them. If there's some reason a patch shouldn't be applied please let me know so that I can stop worrying about that subissue.
Thanks, I'll take a look.
--
``The lyf so short, the craft so long to lerne.'' - Chaucer
``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, UTech, CWRU c...@case.edu http://tiswww.cwru.edu/~chet/
OpenPGP_signature.asc
Description: OpenPGP digital signature
